-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable dev ports #16736
Configurable dev ports #16736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it 👏
I will happily replace my crappy aliases to use these variables instead when starting my dev servers
On this branch when accessing
I'm not sure how the |
I have fixed the proxy issue by amending the .env.example file. It must use the I have also amended the Either way this fix needed to align with your PR, however, which is why I made it on this branch. I've tested both the direct and docker setups and they both work as expected for me now. So from my perspective this is good to be merged. But it would indeed be a good idea to ask someone from the @opf/titan team to double check their docker setup with TLS is still working with these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Looking great - Please hold merging until @Kharonus / @apfohl have a look as they're more familiar with the Titan docker setup. I couldn't get this PR to work with the Docker TLS setup out of the box with the following env: I'm likely missing sth obvious. # Local backend development host and port
HOST=openproject.local
PORT=3000
# Local frontend development host and port
FE_HOST=openproject.local
FE_PORT=4200 Kapture.2024-09-19.at.13.25.30.mp4 |
04bc286
to
9cd9ea7
Compare
…and default to 127.0.0.1
…ed localhost:3000
…otenv-rails changes environment
Co-authored-by: Ivan Kuchin <[email protected]>
Co-authored-by: Ivan Kuchin <[email protected]>
Co-authored-by: Ivan Kuchin <[email protected]>
9cd9ea7
to
7d2f684
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What are you trying to accomplish?
Make it possible to configure both backend and frontend host/port using environment variables (or .env file).
Merge checklist